Use serial instead of SCSI ID for USB devices #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-bor
force-pushed
the
fix/multiple-usb-devices
branch
from
6727526 to
9946f5e
Compare
Wescoeur
requested changes
Nov 14, 2025
Member
|
Hi! Thank you for your contribution. Could you please sign-off your commit after taking the suggestions into account? |
Member
|
Also IMHO a commit like |
Wescoeur
reviewed
Nov 14, 2025
f-bor
changed the title
f-bor
force-pushed
the
fix/multiple-usb-devices
branch
2 times, most recently
from
e464d66 to
9802153
Compare
Wescoeur
requested changes
Nov 17, 2025
drivers/util.py
Outdated
Comment on lines
1073
to
1074
| except CommandException: | ||
| usb_device_with_serial = False |
Member
There was a problem hiding this comment.
Suggested change
| except CommandException: | |
| usb_device_with_serial = False | |
| except Exception as e: | |
| usb_device_with_serial = False | |
| SMlog(f"Unable to check if device is USB: {e}") |
Author
There was a problem hiding this comment.
I'm not a big fan of broad exception catch but ok. Regarding the log, just using f-string interpolation on exception is often not very helpful. Would it be ok for you to do the log like this:
Suggested change
| except CommandException: | |
| usb_device_with_serial = False | |
| except: | |
| usb_device_with_serial = False | |
| SMlog("Unable to check if device is USB:") | |
| SMlog(traceback.format_exc()) |
Member
There was a problem hiding this comment.
You can commit your suggestion, not a blocking point I guess.
Signed-off-by: Frederic Bor <[email protected]>
f-bor
force-pushed
the
fix/multiple-usb-devices
branch
from
9802153 to
ce6361c
Compare
Wescoeur
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding SRs on multiple usb devices may fail because /usr/lib/udev/scsi_id returns the same device id for all the usb devices.
This PR fixes this by checking the drive type and using the device serial number if correctly read.